Skip to content

fix(alloydb): user supports password_wo and password_wo_version#16740

Open
enocom wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
enocom:main
Open

fix(alloydb): user supports password_wo and password_wo_version#16740
enocom wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
enocom:main

Conversation

@enocom
Copy link
Member

@enocom enocom commented Mar 17, 2026

An earlier commit 1 added incomplete support for these two fields. This commit corrects the partial support by ensuring updates to the user are sent through PATCH calls and include the password in the update mask when password_wo_version changes.

Fixes hashicorp/terraform-provider-google/issues/25089.

Release Note Template for Downstream PRs (will be copied)

alloydb: fix `password_wo` and `password_wo_version` fields in `google_alloydb_user` resource

An earlier commit added incomplete support for these two fields. This
commit corrects the partial support by ensuring updates to the user are
sent through PATCH calls and include the password in the update mask
when password_wo_version changes.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 17, 2026
@enocom enocom marked this pull request as ready for review March 17, 2026 16:30
@github-actions github-actions bot requested a review from NickElliot March 17, 2026 16:31
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@enocom
Copy link
Member Author

enocom commented Mar 19, 2026

@NickElliot Would you mind taking a pass on this?

@github-actions
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/alloydb and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 20, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 54 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 1 file changed, 54 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 92
Passed tests: 85
Skipped tests: 3
Affected tests: 4

Click here to see the affected service packages
  • alloydb

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbUser_alloydbUserBuiltinWithPasswordWo_update
  • TestAccAlloydbUser_updatePassword_BuiltIn
  • TestAccAlloydbUser_updateRoles_BuiltIn
  • TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbUser_alloydbUserBuiltinWithPasswordWo_update [Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn [Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn [Debug log]
TestAccAlloydbUser_updateRoles_IAM [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for write only values in google_alloydb_user password field

2 participants